Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor change to sparse to handle all 0 delays #696

Merged
merged 1 commit into from
May 17, 2023
Merged

Minor change to sparse to handle all 0 delays #696

merged 1 commit into from
May 17, 2023

Conversation

PhilippPlank
Copy link
Contributor

@PhilippPlank PhilippPlank commented May 16, 2023 •
edited
Loading

Objective of pull request: Sparse process should be able to handle all 0 delays.

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@PhilippPlank PhilippPlank self-assigned this May 16, 2023
@PhilippPlank PhilippPlank added 1-refactor Suggestion to refactor part of the code 1-bug Something isn't working and removed 1-refactor Suggestion to refactor part of the code labels May 16, 2023
@weidel-p weidel-p merged commit 4beccfa into main May 17, 2023
@PhilippPlank PhilippPlank deleted the Minor_change_to_sparse branch May 22, 2023 14:55
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@PhilippPlank
Update models.py (lava-nc#696)
05d29e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkarray gkarray gkarray approved these changes

@weidel-p weidel-p weidel-p approved these changes

@bamsumit bamsumit Awaiting requested review from bamsumit

Assignees

@PhilippPlank PhilippPlank

Labels
1-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilippPlank @weidel-p @gkarray